Handle OperationCanceledException in RPC continuations
#1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1750
branch
from
a3e2a69 to
a3618c6
Compare
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1750
branch
from
42c5baa to
f8d2955
Compare
projects/RabbitMQ.Client/ConsumerDispatching/ConsumerDispatcherChannelBase.cs
Outdated
Show resolved
Hide resolved
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1750
branch
3 times, most recently
from
42aa2ae to
59fa75c
Compare
Fixes #1750 * Start by adding a test that demonstrates the error. Give a 5ms cancellation to `BasicConsumeAsync`, with a much longer delay via a hacked RabbitMQ. If running in debug mode, you will see the same `task canceled` exception, but it does not propagate to the test itself. * Set cancellation correctly for TaskCompletionSource in AsyncRpcContinuation * Handle continuation cancellation and timeouts correctly * Refactor repeated code * Add wait on `RegisteredAsync` to see how the changes in #1750 affect the order of operations. * Check to ensure no connection shutdown in `TestBasicConsumeCancellation_GH1750` * @danielmarbach noticed an improvement. Do not elide `await` here. * Extend GHA timeout for Windows builds, yuck (see actions/runner-images#7320)
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1750
branch
from
59fa75c to
cc16b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750