Add read to file:open/2 options in ra_lib:sync_file/1
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [file:open/2] docs: > `write` - The file is opened for writing. It is created if it does not > exist. If the file exists and `write` is not combined with `read`, the > file is truncated. Without this change, checkpoints which are promoted to snapshots end up as empty snapshot files. [file:open/2]: https://www.erlang.org/doc/apps/kernel/file.html#open/2 Co-authored-by: Karl Nilsson <[email protected]>
This ensures that we can recover from a snapshot which was promoted from a checkpoint. The restart earlier in the test case ensures that we can recover from a checkpoint but that doesn't provide an insights about checkpoint promotion. Without the fix for `ra_lib:sync_file/1` in the parent commit, this case fails on the new calls to `ra:restart_server/2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where checkpoints which were promoted to snapshots would become empty. We need to
file:open/2the checkpoint file with thereadoption as well aswritesincewritewithoutreadtruncates the file.We also add another server restart to the checkpoint promotion case which catches the failure - the servers failed to restart since the promoted snapshot is empty.