Fixes to ra_leaderboard module #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the members are updated when the membership is modifiied. Always delete leaderboard record in ra server terminate callback to favour accuracy of leadership information over availability. The idea is that when a record is not found in the leaderboard the caller falls back to some other, potentially slower, means of leader discovery.
kjnilsson
force-pushed
the
ra-leaderboard-fixes
branch
from
6f79246
to
b18ab08
Compare
dumbbell
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
The test of rabbitmq/khepri#240 (to use ra_leaderboard:lookup_members/1) works with this patch!
It failed with Ra 2.7.1.
nice, thanks for testing, I'll release a new Ra patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the members are updated when the membership
is modifiied.
Always delete leaderboard record in ra server terminate callback
to favour accuracy of leadership information over availability.
The idea is that when a record is not found in the leaderboard
the caller falls back to some other, potentially slower, means
of leader discovery.