Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khepri_cluster: Accept machine_config in Ra server config #167

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Nov 8, 2022

It is now possible to pass state machine arguments in the Ra server config. This is handy to e.g. set the snapshot interval:

RaServerConfig = #{cluster_name => StoreId,
                   machine_config => #{snapshot_interval => 10000}},
khepri:start(RaSystem, RaServerConfig).

It is now possible to pass state machine arguments in the Ra server
config. This is handy to e.g. set the snapshot interval:

    RaServerConfig = #{cluster_name => StoreId,
                       machine_config => #{snapshot_interval => 10000}},
    khepri:start(RaSystem, RaServerConfig).
@dumbbell dumbbell added the enhancement New feature or request label Nov 8, 2022
@dumbbell dumbbell added this to the v0.6.0 milestone Nov 8, 2022
@dumbbell dumbbell self-assigned this Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 90.98% // Head: 90.99% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9488876) compared to base (5d38c39).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   90.98%   90.99%           
=======================================
  Files          18       18           
  Lines        3163     3166    +3     
=======================================
+ Hits         2878     2881    +3     
  Misses        285      285           
Flag Coverage Δ
erlang-24 89.63% <100.00%> (+0.10%) ⬆️
erlang-25 89.54% <100.00%> (-0.12%) ⬇️
os-ubuntu-latest 90.99% <100.00%> (+0.07%) ⬆️
os-windows-latest 89.54% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/khepri_cluster.erl 80.39% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dumbbell
Copy link
Member Author

dumbbell commented Nov 8, 2022

This helps with #144 but doesn't solve it magically.

@dumbbell dumbbell marked this pull request as ready for review November 8, 2022 16:35
@dumbbell dumbbell merged commit e4f7f89 into main Nov 9, 2022
@dumbbell dumbbell deleted the allow-to-set-machine-config-params branch November 9, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants