Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message + tweak function signature respect error_arg for allow_rename = FALSE #358

Closed
wants to merge 6 commits into from
Closed

Improve error message + tweak function signature respect error_arg for allow_rename = FALSE #358

wants to merge 6 commits into from

Commits on Oct 23, 2024

  1. use_standalone("r-lib/rlang") purrr and obj-type + update snaps… 

    …hots
    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    519267e View commit details
    Browse the repository at this point in the history

  2. Tweak function signature to be more consistent

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    05149d8 View commit details
    Browse the repository at this point in the history

  3. Use regular snapshot tests with cnd_class

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e734c6c View commit details
    Browse the repository at this point in the history

  4. use standard type checking

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a761011 View commit details
    Browse the repository at this point in the history

  5. Respect error_arg with allow_rename = FALSE

    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9938eb5 View commit details
    Browse the repository at this point in the history

  6. Standardize on putting cnd_class = TRUE on the same line to make it… 

    … easier to remove if they are judged as not useful for some tests, with a cleaner diff (i.e. no comma to remove)
    @olivroy
    olivroy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    972a200 View commit details
    Browse the repository at this point in the history