Skip to content

Commit

Permalink
Fix grammar in warning about bare predicates (#349)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewjnield authored Oct 22, 2024
1 parent fd22cc1 commit 42f32e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion R/eval-walk.R
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ eval_sym <- function(expr, data_mask, context_mask, strict = FALSE) {
# Formally deprecated in 1.2.0
lifecycle::deprecate_soft("1.1.0",
what = I("Use of bare predicate functions"),
with = I("wrap predicates in `where()`"),
with = I("`where()` to wrap predicate functions"),
details = c(
" " = "# Was:",
" " = glue("data %>% select({name})"),
Expand Down
8 changes: 4 additions & 4 deletions tests/testthat/_snaps/eval-walk.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
Condition
Warning:
Use of bare predicate functions was deprecated in tidyselect 1.1.0.
i Please use wrap predicates in `where()` instead.
i Please use `where()` to wrap predicate functions instead.
# Was:
data %>% select(is_integer)
Expand All @@ -102,7 +102,7 @@
Condition
Warning:
Use of bare predicate functions was deprecated in tidyselect 1.1.0.
i Please use wrap predicates in `where()` instead.
i Please use `where()` to wrap predicate functions instead.
# Was:
data %>% select(is.numeric)
Expand All @@ -113,7 +113,7 @@
Condition
Warning:
Use of bare predicate functions was deprecated in tidyselect 1.1.0.
i Please use wrap predicates in `where()` instead.
i Please use `where()` to wrap predicate functions instead.
# Was:
data %>% select(isTRUE)
Expand All @@ -125,7 +125,7 @@
Condition
Warning:
Use of bare predicate functions was deprecated in tidyselect 1.1.0.
i Please use wrap predicates in `where()` instead.
i Please use `where()` to wrap predicate functions instead.
# Was:
data %>% select(is_integer)
Expand Down

0 comments on commit 42f32e7

Please sign in to comment.