fullseq() sorts range
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Oct 8, 2024
Comment on lines
-20
to
-21
| x <- as.Date("2012-01-01") + 1:30 | ||
| expect_equal(fullseq(x, "1 month"), as.Date(c("2012-01-01", "2012-02-01"))) |
There was a problem hiding this comment.
This test was wonky. fullseq() only considers range[1] and range[2], but this is a vector of 30 dates instead of a range of 2 dates.
In addition, ceiling_date("2012-01-01", "1 month") gives 1st of March because 31 days from the end of January is in March due to February typically having only 28 days. I consider this out of scope for this PR, but it isn't doing any real harm anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #435.
Briefly,
fullseq()now sorts the inputrangebefore doing the calculation. This prevents errors about the sign of thebyargument.