Report domains for several transformations #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, ggplot2 uses the domain to figure out in what range it can ask a transformation to compute breaks after scale expansion.
Having a default domain of
c(-Inf, Inf)
works for most transformations, but not all.In particular the
boxcox_trans()
doesn't really work as intended as a consequence of having the default domain. While trying to fix that, I decided to also add domains forasn_trans()
and probability transformations.A short demo of the issue and proposed fix:
Created on 2023-07-25 with reprex v2.0.2