Merge branch 'main' into patch-8

.Rbuildignore

@@ -23,3 +23,4 @@
 ^\.cache$
 ^\.vscode$
 ^compile_commands\.json$
+.*\.clangd$

NEWS.md

@@ -6,6 +6,8 @@
 * `env_unlock()` is now defunct because recent versions of R no long
   make it possible to unlock an environment (#1705). Make sure to use an
   up-to-date version of pkgload (>= 1.4.0) following this change.
+
+* `is_dictionaryish()` now will return TRUE for NULL (@ilovemane, #1712).
 
 
 # rlang 1.1.4

R/attr.R

@@ -20,7 +20,7 @@
 #'   a logical vector as long as the input.
 #'
 #' @details
-#' `is_named()` always returns `TRUE` for empty vectors because 
+#' `is_named()` always returns `TRUE` for empty vectors because
 #'
 #' @examples
 #' # is_named() is a scalar predicate about the whole vector of names:
@@ -110,6 +110,10 @@ detect_void_name <- function(x) {
 is_dictionaryish <- function(x) {
   # 2022-01: Used in many packages. Don't deprecate without a
   # replacement.
+  if (is.null(x)) {
+    return(TRUE)
+  }
+
   if (!length(x)) {
     return(!is.null(x))
   }
@@ -118,6 +122,7 @@ is_dictionaryish <- function(x) {
 }
 
 
+
 #' Does an object have an element with this name?
 #'
 #' This function returns a logical value that indicates if a data

R/rlang-package.R

@@ -18,6 +18,3 @@ compiled_by_gcc <- function() {
 #' @rawNamespace export(ffi_standalone_is_bool_1.0.7)
 #' @rawNamespace export(ffi_standalone_check_number_1.0.7)
 NULL
-
-# Enable pkgload to hotpatch `::` in detached namespaces
-on_load(`::` <- base::`::`)

R/standalone-types-check.R

@@ -1,16 +1,19 @@
 # ---
 # repo: r-lib/rlang
 # file: standalone-types-check.R
-# last-updated: 2024-07-14
+# last-updated: 2024-08-18
 # license: https://unlicense.org
 # dependencies: standalone-obj-type.R
 # imports: rlang (>= 1.1.0)
 # ---
 #
 # ## Changelog
-# 2024-07-14:
+# 2024-08-18:
 # - `check_character()` gains `min_length` to allow prohibiting `character(0)` (@olivroy)
 #
+# 2024-08-15:
+# - `check_character()` gains an `allow_na` argument (@martaalcalde, #1724)
+#
 # 2023-03-13:
 # - Improved error messages of number checkers (@teunbrand)
 # - Added `allow_infinite` argument to `check_number_whole()` (@mgirlich).
@@ -459,16 +462,29 @@ check_formula <- function(x,
 
 # Vectors -----------------------------------------------------------------
 
+# TODO: Figure out what to do with logical `NA` and `allow_na = TRUE`
+
 check_character <- function(x,
                             ...,
+                            allow_na = TRUE,
                             allow_null = FALSE,
                             min_length = 0,
                             arg = caller_arg(x),
                             call = caller_env()) {
+
   if (!missing(x)) {
     if (is_character(x) && (length(x) >= min_length)) {
+      if (!allow_na && any(is.na(x))) {
+        abort(
+          sprintf("`%s` can't contain NA values.", arg),
+          arg = arg,
+          call = call
+        )
+      }
+
       return(invisible(NULL))
     }
+
     if (allow_null && is_null(x)) {
       return(invisible(NULL))
     }
@@ -483,7 +499,6 @@ check_character <- function(x,
     x,
     what,
     ...,
-    allow_na = FALSE,
     allow_null = allow_null,
     arg = arg,
     call = call