Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show code in \dontshow{} or \testonly{} #2629

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 4, 2024

Fixes #2188

@jennybc could you please review by critiquing the the rendered output at https://665f3ccd6d85660f63dbff76--pkgdown-dev.netlify.app/dev/reference/test-dont generated from the input roxygen2 at https://github.com/r-lib/pkgdown/blob/dont-show-dontshow/R/test.R#L94-L155.

Copy link

github-actions bot commented Jun 4, 2024

@hadley hadley requested a review from jennybc June 4, 2024 16:13
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibble: there are some typos in comments of the test code, e.g. # \donrun{} instead of # \dontrun{}, ditto for # \dontest{} and # \donshow.

Otherwise LGTM in terms of the result!

@hadley hadley merged commit 003d8ea into main Jun 6, 2024
14 checks passed
@hadley hadley deleted the dont-show-dontshow branch June 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do about \dontshow?
2 participants