Always return a bool from restarts (#226)

Fixes #225 I can't remember exactly why this comes up, but clearly in some circumstances rethrowing the error doesn't trigger immediate termination. This shouldn't have widespread effects.
r-lib · Oct 9, 2024 · acb1ba9 · acb1ba9
1 parent 8e0f5e8
commit acb1ba9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # evaluate (development version)
 
+* Fix buglet revealed when by using `rlang::abort()` inside of `evaluate()`.
+
 # evaluate 1.0.0
 
 * Setting `ACTIONS_STEP_DEBUG=1` (as in a failing GHA workflow) will

diff --git a/R/evaluate.R b/R/evaluate.R
@@ -152,7 +152,7 @@ evaluate <- function(input,
       ),
       eval_continue = function() TRUE,
       eval_stop = function() FALSE,
-      eval_error = function(cnd) signalCondition(cnd)
+      eval_error = function(cnd) {signalCondition(cnd); FALSE}
     )
     watcher$check_devices()