Skip to content

Commit

Permalink
Update with revdep results and add cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jimhester committed Jul 1, 2019
1 parent c53a0dd commit cf7ea25
Show file tree
Hide file tree
Showing 4 changed files with 1,427 additions and 4,026 deletions.
17 changes: 15 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
This is a small patch fixing test failures on CRAN
This release removes previously deprecated functions

## Test environments

Expand All @@ -16,4 +16,17 @@ This is a small patch fixing test failures on CRAN

## Downstream dependencies

* I did not test all dependencies, but do not think any of the changes should effect them.
I ran `R CMD check` on all 316 reverse dependencies
(https://github.com/r-lib/devtools/tree/master/revdep) there were 6 regressions
detected.

* available - submitted release 1.0.3 to fix the issue
* googleAuthR - sent PR https://github.com/MarkEdmondson1234/googleAuthR/pull/150 to fix the issue.
* packagedocs - sent PR https://github.com/hafen/packagedocs/pull/32 to fix the issue.
* soilcarbon - sent PR
https://github.com/powellcenter-soilcarbon/soilcarbon/pull/19 to remove the
devtools dependency, the issue also seems to have been already fixed in the
devel version of the package.
* understandBPMN - sent email to maintainer, patch to fix available at
https://github.com/cran/understandBPMN/compare/master...jimhester:remove-devtools.patch
* zebu - sent PR https://github.com/oliviermfmartin/zebu/pull/2 to remove the devtools dependency
Loading

0 comments on commit cf7ea25

Please sign in to comment.