Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poc mmap data sharing #109

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add poc mmap data sharing #109

wants to merge 4 commits into from

Conversation

gaborcsardi
Copy link
Member

Unix only. Uses r-lib/processx#201

This is really a crude poc now. Notes:

  • callr::r supports the transter = "mmap" option now, to transfer all arguments via shared memory.
  • it fails if one argument is not an integer, real, raw or logical vector.
  • it changes how the subprocess runs its R code: it puts a run() function into a callr environment on the search path. This allows more flexible subprocess code.
  • the result is still copied back via a file.
  • it needs a better way of passing the fd of the memory mapped file. Right now it just assumes 3L, but that might change depending on whether we have a poll connection or not, or possibly other connections.

@gaborcsardi gaborcsardi force-pushed the feature/mmap branch 5 times, most recently from 9754be4 to c540791 Compare June 28, 2019 11:06
@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #109 into master will increase coverage by 10.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
+ Coverage   74.39%   84.48%   +10.09%     
===========================================
  Files          20       20               
  Lines        1070      986       -84     
===========================================
+ Hits          796      833       +37     
+ Misses        274      153      -121
Impacted Files Coverage Δ
R/package.R 0% <ø> (ø) ⬆️
R/eval-bg.R 100% <ø> (ø) ⬆️
R/eval.R 100% <ø> (ø) ⬆️
R/check.R 100% <100%> (ø) ⬆️
R/run.R 100% <100%> (ø) ⬆️
R/r-session.R 74.14% <100%> (+16.51%) ⬆️
R/setup.R 93.28% <100%> (-2.69%) ⬇️
R/script.R 96.2% <100%> (+6.66%) ⬆️
R/options.R 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b86fe...8fb3a04. Read the comment docs.

This might be temporary, I suspect we'll need to have
more control.
@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants