Update command history in r_session$attach()

r-lib · Jul 15, 2019 · 4031db9 · 4031db9
1 parent 9f7665e
commit 4031db9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/R/r-session.R b/R/r-session.R
@@ -393,6 +393,7 @@ rs_attach <- function(self, private) {
   tryCatch({
     while (TRUE) {
       cmd <- rs__attach_get_input(paste0("RS ", self$get_pid(), " > "))
+      update_history(cmd)
       private$write_for_sure(paste0(cmd, "\n"))
       private$report_back(202, "done")
       private$attach_wait()

diff --git a/R/utils.R b/R/utils.R
@@ -104,3 +104,11 @@ bold <- function(x) {
     get("bold", asNamespace("crayon"))(x),
     error = function(e) x)
 }
+
+update_history <- function(cmd) {
+  tmp <- tempfile()
+  on.exit(unlink(tmp, recursive = TRUE))
+  savehistory(tmp)
+  cat(cmd, "\n", sep = "", file = tmp, append = TRUE)
+  loadhistory(tmp)
+}