Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program builder interface #782

Merged
merged 38 commits into from
Mar 15, 2024
Merged

Program builder interface #782

merged 38 commits into from
Mar 15, 2024

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Aug 18, 2023

  • Make existing tests pass
  • ~~ Add LoopBuilder tests ~~ (we rely on the Loop based tests)
  • Document visitor interface in docs
  • Mention this is a visitor in ProgramBuilder docstring
  • Newspiece

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Test Results

    6 files      6 suites   3m 35s ⏱️
  687 tests   640 ✅  47 💤 0 ❌
4 122 runs  3 840 ✅ 282 💤 0 ❌

Results for commit ea48f8e.

♻️ This comment has been updated with latest results.

@Nomos11 Nomos11 marked this pull request as ready for review August 20, 2023 10:04
@Nomos11 Nomos11 marked this pull request as draft August 20, 2023 10:06
# Conflicts:
#	qupulse/program/loop.py
#	qupulse/pulses/loop_pulse_template.py
#	qupulse/pulses/mapping_pulse_template.py
#	qupulse/pulses/repetition_pulse_template.py
#	qupulse/pulses/sequence_pulse_template.py
#	tests/pulses/loop_pulse_template_tests.py
#	tests/pulses/mapping_pulse_template_tests.py
#	tests/pulses/pulse_template_tests.py
#	tests/pulses/repetition_pulse_template_tests.py
#	tests/pulses/sequence_pulse_template_tests.py
# Conflicts:
#	qupulse/program/loop.py
@terrorfisch terrorfisch mentioned this pull request Aug 25, 2023
@terrorfisch terrorfisch self-assigned this Mar 15, 2024
@terrorfisch terrorfisch marked this pull request as ready for review March 15, 2024 16:18
@terrorfisch terrorfisch merged commit 2db27d5 into master Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant