Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Make raw_output_present always return data if data is present #542

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Make raw_output_present always return data if data is present #542

merged 1 commit into from
Dec 13, 2017

Conversation

noahl
Copy link

@noahl noahl commented Dec 12, 2017

Move if clause so that raw_output_present always returns data if data is present.

This requires temporarily disabling a test which checked for the old behavior. Also add extrasaction='ignore' to the DictWriter so that it won't error if we pass it extra columns because of this change.

Closes #541 .

@coveralls
Copy link

coveralls commented Dec 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 63.304% when pulling 2967382 on issues/541 into e0135ed on master.

@noahl noahl merged commit 994135a into master Dec 13, 2017
@noahl noahl deleted the issues/541 branch December 13, 2017 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chambridge chambridge chambridge approved these changes

@elyezer elyezer Awaiting requested review from elyezer

@kdelee kdelee Awaiting requested review from kdelee

@kholdaway kholdaway Awaiting requested review from kholdaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahl @coveralls @chambridge