make some cache kind configureable #5469
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of work on #5445
small survey of our caches:
I chose to use moka because i believe it should be possible to re-express the searcher_split_cache using it, which wasn't the case for other most others crates i looked into. Its implementation is a tiny-lfu backed by an lru (essentially an lru with an lfu-based admission policy). This should behave well on changing workload (lru) while ignoring one hit wonders (lfu).
How was this PR tested?
updated tests. tested manually. Behavior on actual load will likely depend on the workload