start adding documentation on updating mapping #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
fmassot
reviewed
Aug 2, 2024
fmassot
reviewed
Aug 2, 2024
fmassot
reviewed
Aug 2, 2024
rdettai
reviewed
Aug 2, 2024
trinity-1686a
force-pushed
the
trinity/update-mapper-doc
branch
from
36528e1
to
02f2edb
Compare
trinity-1686a
commented
Sep 27, 2024
Comment on lines
+643
to
+647
| TantivyValue::F64(number) => match number { | ||
| 0.0 => Some(false), | ||
| 1.0 => Some(true), | ||
| _ => None, | ||
| }, |
There was a problem hiding this comment.
i realized while writing the doc that missing this conversion was odd given u64/i64 had it, and bool->f64 was a thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add documentation on the known limitations when updating a doc mapping
@rdettai i know you were surprised by a few things, please step in if you think I missed anything important
@fmassot you might have opinions on things to add too.
this is based on the expect stat of updates once all currently existing PR on the subject are merged