Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move creation of script before functions that may update it #1577

Merged
merged 1 commit into from
Feb 1, 2025
Merged

fix: move creation of script before functions that may update it #1577

merged 1 commit into from
Feb 1, 2025

Conversation

philclifford
Copy link
Contributor

Description

Move the initialisation of the script to above the functions so that changes they might make (e.g. configure_tpm) are retained.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions

lj3954
lj3954 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@lj3954 lj3954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lj3954 lj3954 merged commit b60ff76 into quickemu-project:master Feb 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lj3954 lj3954 lj3954 approved these changes

@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: the tpm configuration in "${VMDIR}/${VMNAME}.sh" is overwritten
2 participants
@philclifford @lj3954