fix: Disregard curl configuration #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxVinyards
added a commit
to TuxVinyards/qqX
that referenced
this pull request
Jan 28, 2025
ensure consistent download targets quickemu-project/quickemu#1571
TuxVinyards
added a commit
to TuxVinyards/qqX
that referenced
this pull request
Jan 29, 2025
ensure consistent download targets aligns with changes to 1.11.05 and upstream f7ac8ad quickemu-project/quickemu#1571
philclifford
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quickget relies upon specific parameters passed to curl in order to find or download various operating systems. User defined configuration could break this, such as by sending undesired headers or cookies, which could cause requests to be blocked, or as in the case of #1570, to set output flags which cause curl to attempt to download files to invalid or incorrect directories. This issue can be resolved by disregarding the curl configuration file for any and all invocations within quickget, achieved by passing the
--disablecommand line flag.Type of change
Checklist: