download chromedriver according to chrome installed #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if the release schedules are synchronized. There's value in having a (more) deterministic build. |
|
chromedriver complains if it does not match chrome itself. when I updated yesterday chromedriver to 131 (latest), it complained that chrome is 130. since we install the latest chrome (from apt repo), it looks reasonable to align chromedriver with it. other approach would be to define BOTH chrome and chromedriver, but it is longer story |
|
please merged ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you do not mind, I would introduce daily scheduled workflow in the next PR