Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): modify config parsing behavior to match other clients #28

Merged
merged 5 commits into from
Mar 22, 2024
Merged

fix(client): modify config parsing behavior to match other clients #28

merged 5 commits into from
Mar 22, 2024

Conversation

sklarsa
Copy link
Contributor

@sklarsa sklarsa commented Mar 21, 2024

Changes to behavior:

  • Case-sensitive scheme (behavior unchanged, just added a validating test)
  • Case-sensitive keys
  • Require trailing semicolon

@sklarsa sklarsa requested a review from puzpuzpuz March 21, 2024 19:46
@puzpuzpuz puzpuzpuz merged commit 0f785ff into main Mar 22, 2024
2 checks passed
@puzpuzpuz puzpuzpuz deleted the steve/config-parsing-fixes branch March 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sklarsa @puzpuzpuz