-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit:REV-PER-MIN-SEC #1095
base: main
Are you sure you want to change the base?
add unit:REV-PER-MIN-SEC #1095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the CHANGELOG.md?
@VladimirAlexiev care to push this over the finishing line? We'll publish the new release next week. |
All that is missing is to apply our formatting rules |
@fkleedorfer, what is the downside of running mvn spotless:apply as part of a PR build? I realize that means the src files might get changed meaning a user would need to do another git pull, but maybe that makes life easier? They will need to git pull after a merge anyway. |
I don't see how. If it adds a commit, that would happen each time someone pushed to a PR branch, That will cause too much pain. If it does not add a commit but cleans up the code before the other checks, it allows dirty code to enter the codebase. |
But: if you are happy with the changes, and all that is missing is the formatting, and you have write access to the branch, you can run the format action yourself and then merge |
closes #1094