-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute Quantitykinds for frequency and angle, fix unit localnames #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkleedorfer
force-pushed
the
contribute-frequency-and-angle-qks
branch
from
December 2, 2024 15:15
0be4922
to
0f696ba
Compare
fkleedorfer
changed the title
Contribute frequency and angle qks
Contribute Quantitykinds for frequency and angle, fix unit localnames
Dec 2, 2024
… used, relocate qk:IonConcentration and qk:IonDensity to subkind of qk:Concentration, unify NUM-PER-X symbols to always use '#' for NUM
fkleedorfer
force-pushed
the
contribute-frequency-and-angle-qks
branch
from
December 5, 2024 09:50
fb14db5
to
eff3130
Compare
src/main/rdf/vocab/quantitykinds/VOCAB_QUDT-QUANTITY-KINDS-ALL.ttl
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
…nce` to `qk:CurrentOfTheAmountOfSubstance`
… exact matches - Make `qk:RotationalFrequency` exactMatch of `qk:RotationalVelocity` - Make `qk:AngularFrequency` exactMatch of `qk:AngularVelocity`
- fix most resulting INFO messages (some seem out of scope here)
# Conflicts: # CHANGELOG.md
steveraysteveray
approved these changes
Dec 6, 2024
src/main/rdf/vocab/quantitykinds/VOCAB_QUDT-QUANTITY-KINDS-ALL.ttl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
qk:CompoundPlaneAngle
(QK for IfcCompoundPlaneAngleMeasure - plane angle measured in degrees, minutes and seconds? #1043)qk:CountRate
- needed to map IfcIntegerCountRateMeasureqk:RotationalFrequency
- needed to map IfcRotationalFrequencyMeasureFixes
unit:CI-PER-KiloGM
tounit:Ci-PER-KiloGM
unit:Flight
tounit:FLIGHT
(determined wrong because there are derived units using FLIGHT not Flight)