Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit for Okta is missing #1047

Open
Jeffrey-Vervoort-KNMI opened this issue Nov 28, 2024 · 12 comments
Open

Unit for Okta is missing #1047

Jeffrey-Vervoort-KNMI opened this issue Nov 28, 2024 · 12 comments

Comments

@Jeffrey-Vervoort-KNMI
Copy link
Contributor

Jeffrey-Vervoort-KNMI commented Nov 28, 2024

The unit for the measurement of cloud cover is not currently available in the vocabulary. Would it be acceptable for this project if I create a PR to add "Okta" as a unit?

I noticed that there are some guides over here, for when I would be allowed to contribute:

@fkleedorfer
Copy link
Collaborator

Thanks for this suggestion and the offer to make a PR!

It seems like Okta would be a new qudt:Unit, and that it would require the addition of a new qudt:QuantityKind, for example AmountOfCloudCover or CloudCoverIntensity, which would be the qudt:quantityKind of the new unit.

If I understand correctly, the value range would be an integer in [0, 1,2,3,4,5,6,7,8]. I am not sure how we would express that - but @steveraysteveray @jhodgesatmb @ralphtq will weigh in on that.

@Jeffrey-Vervoort-KNMI
Copy link
Contributor Author

The range is slightly larger and includes the value 9, which indicates that the sky is obstructed from view. This obstruction can occur for various reasons, such as fog or an absence of detection. Unlike values 0 to 8, which represent levels of cloudiness –where 0 means no clouds, 1 indicates a few or less clouds, ... 4 represents a half-clouded sky, ... 8 means completely clouded – 9 stands out as a categorical value. I don't know, but hope not that that would make it more complex.

@jhodgesatmb
Copy link
Collaborator

jhodgesatmb commented Nov 29, 2024 via email

@jhodgesatmb
Copy link
Collaborator

I agree with @fkleedorfer that this should be implemented as a qudt:Unit following normal PR submission guidelines conventions, and that a corresponding QuantityKind should be created. The Okta is a measurement of 'cloudiness' and, according to: https://windy.app/blog/okta-cloud-cover.html, @fkleedorfer's suggestion of 'AmountOfCloudCover' seems the most compatible. For now we should not implement a range restriction as that would be on the quantity side, though the resource quoted above even includes a value of 10 (i.e., 0-10 rather than 0-9), for 'no measurment taken'.

@steveraysteveray
Copy link
Collaborator

I'm finally catching up with various discussions. This specific example has great similarity with how we treated unit:RichterMagnitude, which has a quantity kind of quantitykind:EarthquakeMagnitude. I suggest we follow the same pattern. Note that we did not attempt to define the actual values on the Richter scale. Also note the lack of a qudt:conversionMultiplier triple.

@steveraysteveray
Copy link
Collaborator

Mind you, to be consistent with our naming convention, our unit should be renamed to unit:MAGNITUDE_RICHTER I think.

@Jeffrey-Vervoort-KNMI
Copy link
Contributor Author

Do I understand it correctly that it should become something like the following?

Unit:

unit:OKTA
  a qudt:Unit ;
  dcterms:description "\"Okta\" is the unit of measurement describing the amount of cloud cover. Okta is reported in eighths of the celestial dome covered by all clouds visible. The codes represent 0: 0/8, the complete absence of cloud; 1: 1/8 or less, but not zero; 2: 2/8; 3: 3/8; 4: 4/8, half of the sky is covered; 5: 5/8; 6: 6/8; 7: 7/8 or more, but not 8/8; 8: 8/8, sky is completely covered; 9: Sky obscured by fog and/or other meteorological phenomena; /: Cloud cover is indiscernible for reasons other than fog or other meteorological phenomena, or observation is not made."^^rdf:HTML ;
  qudt:conversionMultiplier 1.0 ;
  qudt:conversionMultiplierSN 1.0E0 ;
  qudt:hasDimensionVector qkdv:A0E0L0I0M0H0T0D1 ;
  qudt:plainTextDescription "\"Okta\" is the unit of measurement to describe the amount of cloud cover. Okta is reported in eighths of the celestial dome covered by all clouds visible. The codes represent 0: 0/8, the complete absence of cloud; 1: 1/8 or less, but not zero; 2: 2/8; 3: 3/8; 4: 4/8, half of the sky is covered; 5: 5/8; 6: 6/8; 7: 7/8 or more, but not 8/8; 8: 8/8, sky is completely covered; 9: Sky obscured by fog and/or other meteorological phenomena; /: Cloud cover is indiscernible for reasons other than fog or other meteorological phenomena, or observation is not made." ;
  qudt:hasQuantityKind quantitykind:AmountOfCloudCover ;
  qudt:informativeReference "https://windy.app/blog/okta-cloud-cover.html" ;
  qudt:isoNormativeReference "https://library.wmo.int/viewer/68695/?offset=3#page=514&viewer=picture&o=bookmark&n=0&q=" ;
  rdfs:isDefinedBy <http://qudt.org/2.1/vocab/unit> ;
  rdfs:label "Okta"@en ; .

Quantity kind:

quantitykind:AmountOfCloudCover
  a qudt:QuantityKind ;
  qudt:hasDimensionVector qkdv:A0E0L0I0M0H0T0D1 ;
  qudt:isoNormativeReference "https://library.wmo.int/viewer/68695/?offset=3#page=514&viewer=picture&o=bookmark&n=0&q=" ;
  qudt:plainTextDescription "The amount of the celestial dome covered by all clouds visible." ;
  rdfs:isDefinedBy <http://qudt.org/2.1/vocab/quantitykind> ;
  rdfs:label "Amount of cloud cover"@en .

@steveraysteveray
Copy link
Collaborator

If you remove the conversion multiplier triples (because the scale is not linear) it looks pretty good to me. I (or you) would need to run the validator to be sure.

@jhodgesatmb
Copy link
Collaborator

According to the web page there is also a value of 10, which is associated with not having taken any measurements at all. Although this raises the question about how measurements fit into QUDT (if at all), it at least is part of the definition as far as I can tell. I would suggest adding this to the description.

@fkleedorfer
Copy link
Collaborator

Are you comfortable with forking and making a PR?

@steveraysteveray
Copy link
Collaborator

Adding to @fkleedorfer's question, I would add that we recently clarified our procedures for making contributions. See, for example, our expanded https://github.com/qudt/qudt-public-repo/wiki/GoodGitPractices wiki page.

@Jeffrey-Vervoort-KNMI
Copy link
Contributor Author

@jhodgesatmb I added the value 10 as a / to be consistent with the descriptions of WMO and windy.app. Would that be an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants