Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csaf: read aggregate_severity #1466

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

RTann
Copy link
Contributor

@RTann RTann commented Jan 10, 2025

I am interested in obtaining the aggregate severity of a CSAF advisory. For example: https://security.access.redhat.com/data/csaf/v2/advisories/2024/rhsa-2024_0024.json

It has an aggregate severity of Important. Without this change, I'd have to look at the severity rating of each vulnerability and find the highest (assuming that's how the aggregate is determined 100% of the time). With this change, it's much simpler to obtain.

@RTann RTann force-pushed the aggregate-severity branch 3 times, most recently from f18415f to 0bd77c4 Compare January 10, 2025 18:48
@RTann RTann marked this pull request as ready for review January 10, 2025 18:58
@RTann RTann requested a review from a team as a code owner January 10, 2025 18:58
@RTann RTann requested review from hdonnay and crozzy and removed request for a team January 10, 2025 18:58
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are good, could you please reword the commit?

"Track" implies it's getting recorded somewhere, where this is just adding the required types.

@RTann RTann force-pushed the aggregate-severity branch from 0bd77c4 to 06429a8 Compare January 10, 2025 19:12
@RTann RTann requested a review from hdonnay January 10, 2025 19:12
@RTann RTann changed the title csaf: track aggregate_severity csaf: read aggregate_severity Jan 10, 2025
@hdonnay
Copy link
Member

hdonnay commented Jan 10, 2025

/fast-forward

@github-actions github-actions bot merged commit 06429a8 into quay:main Jan 10, 2025
6 checks passed
@RTann RTann deleted the aggregate-severity branch January 10, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants