Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panlint: Add option to ignore missing inclusion of components/config #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wpoely86
Copy link
Member

Panlint will not issue errors about the missing include for any component in the whitelist.

@wpoely86
Copy link
Member Author

@stdweird have a look

@ned21
Copy link
Contributor

ned21 commented Nov 21, 2019

What's the use case for this?

@wpoely86
Copy link
Member Author

I find the Component X in use, but component config has not been included errors not really helpful. Especially with metaconfig. It means including a lot of extra lines and it doesn't say anything about including the schema.

So far I've mostly ignored the message but now we have Jenkins that is not happy because of it. This allows a way to get around it.

Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whitelist" is not inclusive language - can you please rename all instances of it in this code? Given that it's really about ignoring a specific test, perhaps --ignore-missing-component-config would be a better name?

Although I also have concerns about this being a special case of a general issue, and a more configuration option would make sense?

@ned21 ned21 changed the title Allow 'whitelisting' of components in panlint panlint: Add option to ignore missing inclusion of components/config Jun 28, 2021
@jrha
Copy link
Member

jrha commented Jun 28, 2021

Additionally, can you add tests for whatever you implement please.

@jrha jrha added this to the 10.9 milestone Jun 23, 2023
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
panc/src/main/scripts/panlint/panlint.py Outdated Show resolved Hide resolved
@ned21
Copy link
Contributor

ned21 commented Oct 27, 2024

Looking good - can you please squash the commits and amend the commit message of 7c891c0?

Panlint will not issue errors about the missing include for any component in the ignore list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants