feat: honor EOF as graceful exit #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxandersen
force-pushed
the
graceexit
branch
from
3548b77 to
ad60047
Compare
Well, the spec shows in a diagram that it's the client that closes the stdin and terminates subprocesses but I agree that it's reasonable to exit the app when EOF is reached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this do graceful exit when EOF because when you quit Claude Desktop java processes keeps hanging around as no signal is otherwise sent.
Also stdio spec at https://spec.modelcontextprotocol.io/specification/2024-11-05/basic/transports/ states "Close stdin, terminate subprocess"
Thus I think this is actual a bug/missing feature.