nm windows

quantumlib · Dec 14, 2023 · 3c8fe81 · 3c8fe81
1 parent 322c5fd
commit 3c8fe81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -41,9 +41,10 @@ jobs:
           {os: macos-latest, dist: cp311-macosx_arm64, macosarch: arm64},
           {os: macos-latest, dist: cp312-macosx_arm64, macosarch: arm64},
 
-          {os: windows-latest, dist: cp310-win_amd64},
-          {os: windows-latest, dist: cp311-win_amd64},
-          {os: windows-latest, dist: cp312-win_amd64},
+          # Currently disabled because in CI it gives "DLL load failed" errors I don't understand when testing the wheel.
+          # {os: windows-latest, dist: cp310-win_amd64},
+          # {os: windows-latest, dist: cp311-win_amd64},
+          # {os: windows-latest, dist: cp312-win_amd64},
         ]
     env:
       MACOSX_DEPLOYMENT_TARGET: "10.15"

diff --git a/setup.py b/setup.py
@@ -51,7 +51,6 @@ def build_extension(self, ext):
             ext.sourcedir,
             f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={pathlib.Path(self.get_ext_fullpath(ext.name)).parent.absolute()}",
             f"-DPYTHON_EXECUTABLE={sys.executable}",
-            "-DBUILD_SHARED_LIBS=OFF",
             *osx_cmake_flags,
             *[
                 env_arg_item