Fix serialization support for dataclasses #339
Conversation
Fixes serialization of ReadoutScanTask in data_collection.ipynb notebook.
| @@ -213,8 +213,9 @@ def wrap(cls): | |||
|
|
|||
| cls._json_namespace_ = classmethod(lambda obj: namespace) | |||
|
|
|||
| cls._json_dict_ = classmethod(lambda obj: cirq.obj_to_dict_helper( | |||
| obj, [f.name for f in dataclasses.fields(cls)])) | |||
| cls._json_dict_ = lambda obj: cirq.obj_to_dict_helper( | |||
There was a problem hiding this comment.
Are you sure, this is what I changed here:
#337
and it failed with the message "requiring positional argument obj"
There was a problem hiding this comment.
I am looking at https://quantumai.google/cirq/dev/serialization#adding_a_new_serializable_value and to my understanding _json_dict_ needs to be an instance method to return the instance data.
I left the _json_namespace_ a classmethod - as it was set in your PR. I have also updated the test_json_serializable_class unit test which fails at master, but passes in this PR. Finally, I did a quick test run of the failing notebooks data_collection.ipynb and data_analysis.ipynb which seem to work after this change.
There was a problem hiding this comment.
Ah, yes, you are correct. I got json_dict and json_namespace confused.
TestClass._json_dict_()needs to be an instance method.Fixes serialization of ReadoutScanTask in data_collection.ipynb notebook.