Skip to content

Commit

Permalink
Disable publication_test.py (#338)
Browse files Browse the repository at this point in the history
Disable publication test.

This test doesn't do much besides fetch an external URL and then check that the files exist.

However, this isn't really great as a unit test, since we shouldn't be fetching external URLs during a unit test (and, depending on network availability and other external factors, this could fail).
  • Loading branch information
dstrain115 authored Jan 26, 2024
1 parent e0d1e1f commit c3dc8c1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion recirq/fermi_hubbard/publication_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
from recirq.fermi_hubbard.publication import fetch_publication_data


def test_fetch_publication_data():
def try_fetch_publication_data():
"""Tests fetching publication data from dryad.
Note that this will not run as part of CI, to avoid external URL fetches.
"""
base_dir = "fermi_hubbard_data"
fetch_publication_data(base_dir=base_dir, exclude=["trapping_3u3d"])

Expand Down

0 comments on commit c3dc8c1

Please sign in to comment.