Correct passing of arguments optimize->optimize
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`optimise` expects a dict, not many kwargs
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 85.74% 85.70% -0.05%
==========================================
Files 31 31
Lines 2203 2203
Branches 404 404
==========================================
- Hits 1889 1888 -1
- Misses 232 233 +1
Partials 82 82 ☔ View full report in Codecov by Sentry. |
|
Great stuff - thanks for fixing this @ianhi ! |
quantumjot
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an American friend I've been using
optimizeand just ran into a bug when I tried to pass an option.optimiseexpects a dict, not many kwargs