-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify some variable names and save by file stem as default #391
Conversation
Preview page for your plugin is ready here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name changes are good and it makes sense to set the name based on the filename. It would be great if here:
Line 375 in b4cad6a
config_name = configs.add_config(filename=load_path, overwrite=False) |
you check if the config name already exists and if so either:
- automatically change the config name (e.g. append a
1
ora
) - ask the user if they want to overwrite the existing config or cancel
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 85.74% 85.74%
=======================================
Files 31 31
Lines 2202 2203 +1
Branches 404 404
=======================================
+ Hits 1888 1889 +1
Misses 232 232
Partials 82 82
☔ View full report in Codecov by Sentry. |
Have tried and failed to do the latter. My plan was that it would exit and tell the user that they need to adjust the filename. See my attempt #392, but I don't have time to continue this. Can you please unblock me? |
Fixes #243