-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to hypothesis tab #378
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8c001e1
Rename tab
paddyroddy ba88a7e
Rename functions to reflect name change
paddyroddy c54584e
Add flag to enable optimisation
paddyroddy df6754d
Add optimisation button
paddyroddy aec5f0d
Add optimise to reset button test
paddyroddy d9f7e1d
Merge branch 'main' into fix-issue-371
paddyroddy 127b20e
Merge branch 'main' into fix-issue-371
paddyroddy ac59272
Change the order of update methods to reflect new tabs
paddyroddy aa2ff36
Rename enable optimisation
paddyroddy 3b33318
Add `enable_optimisation` to the `pydantic` model
paddyroddy 2eca6af
Re-use constant
paddyroddy ce3f8fe
Merge branch 'main' into fix-issue-371
paddyroddy ff0a886
`|` for the win
paddyroddy 9f2a0c4
Add back in `relax` and use `isChecked` rather than `value`
paddyroddy ea947a8
Change to `.checkState(`
paddyroddy 622a82b
Restore the test value to `0.001`
paddyroddy c332ad2
Add a warning if the user incorrectly optimises
paddyroddy 9abda19
Rename tab to `Basic`
paddyroddy 162bd97
Fix `prob_not_assign` coming from `motion_model`
paddyroddy deec4ce
Volume doesn't seem to be set correctly
paddyroddy 17ea87b
Fix names in the test
paddyroddy c8de9c9
Revert volume change
paddyroddy 14b2ed8
Adjust config file before running `configure`
paddyroddy 2b5e0d3
Update widget tooltip
paddyroddy fc9bb9c
Make logo smaller
paddyroddy 09b4568
Move scale variable
paddyroddy 39c5193
Callback to disable optimiser tab by name
paddyroddy 6964f3d
Capitals for the win
paddyroddy 1dad9cb
Move track widget above config
paddyroddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the best way I could get it without relying on index @p-j-smith
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paddyroddy I think that's an okay way to do it. Or if you prefer you can get the index of one of the tabs using the widget we put in that tab. As we're not storing the widget itself, you could use one of the child widgets (e.g.
hypotheses
) and find its parent:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw that, but I'm not convinced it's any better! Especially as some widgets have moved tabs