Change values from 0.001 to 0.1 / use config from btrack-examples
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
commented
Aug 7, 2023
There was a problem hiding this comment.
Apparently this should never have been here
|
Preview page for your plugin is ready here: |
|
I think the changes will need to be made in the example configs (https://github.com/lowe-lab-ucl/btrack-examples) rather than here, as the defaults are essentially overridden and set using the example |
p-j-smith
approved these changes
Aug 7, 2023
paddyroddy
commented
Aug 7, 2023
| @@ -55,8 +55,7 @@ instance | |||
| lib | |||
| lib64 | |||
| local_settings.py | |||
| models/MDCK_* | |||
| models/test_config.json | |||
| models | |||
There was a problem hiding this comment.
We don't need this folder at all now
paddyroddy
commented
Aug 7, 2023
| filename = CONFIG_FILE | ||
| assert isinstance(filename, Path) | ||
| assert isinstance(filename, str) |
There was a problem hiding this comment.
This test seems a bit stupid. But I'll leave it here for now
paddyroddy
changed the title
0.001 to 0.10.001 to 0.1 / use config from btrack-examples
|
PR changed purpose a bit. Now also fixes #375. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372