-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch out magicgui
in favour of QtWidgets
#350
Conversation
Preview page for your plugin is ready here: |
We do this by inheriting from QScrollArea rather than QWidget
TODO: - update layer name when it is changed - remove the item from the QComboBox when the layer is deleted
QCheckBox.setCheckState doesn't accept booleans as its for setting tristate checkboxes
The latter is for tristate checkboxes
Fix the scaling of the config (sigmas are attributes not methods)
I'm having a quick play with it and it looks great. I've noticed an error, when swapping between cell and particle tracking modalities:
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 85.26% 86.02% +0.76%
==========================================
Files 30 30
Lines 1975 2097 +122
Branches 301 316 +15
==========================================
+ Hits 1684 1804 +120
- Misses 209 213 +4
+ Partials 82 80 -2
☔ View full report in Codecov by Sentry. |
huh, it's strange that I didn't get that error, but it should be sorted now - I've changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I suspect we'll find some other things as we use it more, but I don't want to impede the changeover.
I've had a play and seems to be all working now. As you said @quantumjot, there might be issues, but it is expected as this was a huge piece of work. I will quickly read over the changes once more and merge. |
@@ -26,5 +16,4 @@ | |||
"dist_thresh", | |||
"time_thresh", | |||
"apop_thresh", | |||
"relax", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this now, but just to check. @p-j-smith relax
got removed because it should have never been in this list, right?
Fixes #352
This is needed as the first step in #266