Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a small drop in coverage (due to flakiness) #238

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

paddyroddy
Copy link
Collaborator

For example, #231 is labelled as failing, although nothing in the python has changed https://app.codecov.io/gh/quantumjot/btrack/pull/231. This change means that we can allow a small drop. 0.5% is an arbitrary choice, so if any strong views let me know.

@paddyroddy paddyroddy self-assigned this Mar 21, 2023
@paddyroddy paddyroddy changed the title Threshold codecov Allow a small drop in coverage (due to flakiness) Mar 21, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (de6e9b8) 82.78% compared to head (19f30c0) 82.78%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          19       19           
  Lines        1545     1545           
  Branches      262      262           
=======================================
  Hits         1279     1279           
  Misses        191      191           
  Partials       75       75           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/238
Created: 2023-03-21T11:30:00.199399

Copy link
Owner

@quantumjot quantumjot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@paddyroddy paddyroddy merged commit 1d09619 into main Mar 21, 2023
@paddyroddy paddyroddy deleted the threshold-codecov branch March 21, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants