Fix installation paths. #32
Conversation
GNUInstallDirs was not defined when target_include_directories was set. This caused it to be blank and the cmake target import failed. User projects importing the cmake target should use include qualisys_cpp_sdk/RTProtocol.h etc. Signed-off-by: James Goppert <[email protected]>
Signed-off-by: James Goppert <[email protected]>
|
I confirm this is required on your Nvidia jetson platforms. |
| @@ -648,7 +648,7 @@ bool CRTProtocol::GetCapture(const char* pFileName, bool bC3D) | |||
| } | |||
| else | |||
| { | |||
| sprintf(maErrorStr, "No packet received. %s.", maErrorStr); | |||
| snprintf(maErrorStr, 1060, "No packet received. %s.", maErrorStr); | |||
There was a problem hiding this comment.
should this be part of the PR?
There was a problem hiding this comment.
Using snprintf(maErrorStr, 1060, "No packet received. %s.", maErrorStr); to avoid the compiler warning and potentially preventing buffer overflows seems reasonable. 👍 Although I suppose it could be a separate PR.
Maybe it's obvious, but where did a size of 1060 come from?
There was a problem hiding this comment.
I agree this should be s separate PR. Also curious where 1060 comes from, as maErrorStr is 1024 characters.
|
Like @MaximilienNaveau pointed out, his approach in #45 also addresses this issue by hardcoding If there are any additional insights I should be aware of, please let me know. (: |
I believe this PR is better suited to be merge than mine I closed mine in response |
There was a problem hiding this comment.
I did the same in nim65s@c39f643, but forgot to open a PR, so thanks for this !
|
@jgoppert : could you consider adding nim65s@1ba8cdb to this PR ? |
GNUInstallDirs was not defined when target_include_directories was set. This caused it to be blank and the cmake target import failed. User projects importing the cmake target should use include qualisys_cpp_sdk/RTProtocol.h etc.