Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login screen #685

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Login screen #685

wants to merge 11 commits into from

Conversation

molon
Copy link
Collaborator

@molon molon commented Oct 26, 2024

No description provided.

@theplant-ci
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@molon
Copy link
Collaborator Author

molon commented Oct 26, 2024

/test all

@theplant-ci
Copy link

@molon: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test pull-qor5-plantbuild-verify

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

deepsource-io bot commented Oct 26, 2024

Here's the code health analysis summary for commits 23d986b..b2bbda7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Go LogoGo✅ Success
🎯 2 occurences resolved
View Check ↗

Code Coverage Report

MetricAggregateGo
Composite Coverage42.2%42.2%
Line Coverage42.2%42.2%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 44 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
login/views.go 78.43% 42 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
example/admin/auth.go 29.41% <100.00%> (ø)
login/messages.go 0.00% <ø> (ø)
login/view_common.go 32.92% <100.00%> (+0.60%) ⬆️
login/views.go 47.78% <78.43%> (+13.83%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants