Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix clearRecentDocuments not emptying the file box #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fauxpark
Copy link
Member

Description

I'm not really sure why this has happened, but clearRecentDocuments() is no longer being called. Although the recent documents list is getting cleared properly, it does not trigger this function which removes the recent files from the combo box.

Only after adding @IBAction does it work again, but this introduces a new issue - the menu item is now always enabled even when the list is empty, whereas before presumably the underlying NSDocumentController controlled this property.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team March 22, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants