feat: add onError and onRender callbacks #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanlahti
reviewed
Nov 12, 2024
johanlahti
approved these changes
Nov 12, 2024
Co-authored-by: Johan Lahti <[email protected]>
quanho
approved these changes
Nov 12, 2024
niekvanstaveren
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds on error and on render callbacks to the nebbie.render call.
Exposes internal render errors as RenderError + originalError
Original motivation is to make it easier for QlikEmbed to be debugged as currently any error during the loading process of the chart is just swallowed. Only tested initially with those types of errors, but could be expanded to let charts expose their own error handling as well.
Requirements checklist
yarn specWhen build and tests have passed: