Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context-menu): new sheet experiment #1631

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

linhnguyen-qlik
Copy link
Collaborator

@linhnguyen-qlik linhnguyen-qlik commented Oct 16, 2024

Motivation

Expose the getContextMenu function so we could use it in QmfeEmbed. This function take features as one of it's parameter and return a list of features that might have been modified by the chart.

Question:

  • Should we called it something else to differentiate between the new and old one?

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@linhnguyen-qlik linhnguyen-qlik marked this pull request as draft October 16, 2024 12:39
@linhnguyen-qlik linhnguyen-qlik changed the title Lgu/new sheet feat(context-menu): new sheet experiment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant