-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: load-qebil-downloaded-studies #3112
base: dev
Are you sure you want to change the base?
Conversation
scripts/qiita-load-qebil-downloads
Outdated
|
||
|
||
SLEEP_TIME = 10 | ||
EBIDIR = '/panfs/panfs1.ucsd.edu/panscratch/qiita/qebil/vertebrates/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vertebrates?
scripts/qiita-load-qebil-downloads
Outdated
# note necessry but nice for debugging | ||
print(f'\n\n\n+++> Processing {folder}, you have {SLEEP_TIME} ' | ||
'seconds to ctrl-c') | ||
sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the sleep for?
qebil_status_fp = [f for f in files if f.endswith('qebil_status')][0] | ||
with open(qebil_status_fp, 'r') as fp: | ||
qebil_status = fp.readlines()[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is qebil being executed? The filebased process communication may represent a pain point in the future.
continue | ||
files_used.append(qebil_status_fp) | ||
|
||
title_fp = [f for f in files if f.endswith('_study_title.txt')][0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be erroneous if there were zero _study_title.txt
files, or more than 1?
scripts/qiita-load-qebil-downloads
Outdated
st = study.sample_template | ||
sample_info = load_sample_template_from_cmd(sample_fp, study.id) | ||
st.ebi_sample_accessions = st.get_category('secondary_sample_accession') | ||
st.biosample_accessions = st.get_category('sample_accession') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, would it be valuable to test if the accessions were observed already in qiita in addition to the study title? although, I'm not sure what action it would suggest if they were :/
scripts/qiita-load-qebil-downloads
Outdated
|
||
filepaths = [] | ||
for rp in run_prefixes: | ||
matches = sorted([f for f in files if rp in f]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be if f.startswith(rp)
?
prep_template=pt, move_files=False) | ||
notes = '' | ||
if warnings: | ||
notes = '<b>Warnings</b>:<ol>%s</ol>\n' % ''.join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
html formatting here feeeeels like it should be done at the visualization layer on template render, but I would understand why doing so here is pragmatic
No description provided.