Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: adding pyproject.toml #21

Merged
merged 27 commits into from
Aug 13, 2024
Merged

MAINT: adding pyproject.toml #21

merged 27 commits into from
Aug 13, 2024

Conversation

lizgehret
Copy link
Member

testing out pyproject.toml to mostly replace setup.py - proof of concept here and then will think about expanding to all q2-plugins.

@lizgehret lizgehret self-assigned this Jul 30, 2024
@lizgehret
Copy link
Member Author

lizgehret commented Jul 30, 2024

TODOs:

  • fix broken conda
  • move everything over to pyproject.toml so that setup.py & friends can all be fully deleted

@lizgehret
Copy link
Member Author

alright this is still completely falling over at the build-package step. tricky to troubleshoot with the actionAdapter. going to pivot to curveplot fot the next week and come back to this.

@lizgehret
Copy link
Member Author

so a weird thing is happening here where the checkout action isn't using the correct ref, which isn't allowing any tags to be pulled from vizard's repo - it's just checking out the merge ref which is putting it in a detached head state. this is where the discrepancy between versions is coming from... i'm going to merge this PR to see if after the changes here are incorporated into main, this resolves the issue - but will continue to address in a new PR if this doesn't fix it.

@lizgehret lizgehret merged commit ccb3887 into dev Aug 13, 2024
4 of 6 checks passed
@lizgehret lizgehret deleted the pyproject-toml branch August 13, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

1 participant