Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: adds lxml as a test req #158

Merged
merged 1 commit into from
Dec 15, 2023
Merged

CI: adds lxml as a test req #158

merged 1 commit into from
Dec 15, 2023

Conversation

lizgehret
Copy link
Member

lxml is being added as a test dependency because assert_no_nans_in_tables is imported from the framework and used in test_basic and test_sample_single. This failed Prepare PR is where this was discovered.

@lizgehret lizgehret merged commit 9f0b11b into dev Dec 15, 2023
3 checks passed
@lizgehret lizgehret deleted the add-lxml-test-dep branch December 15, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

1 participant