Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test conv #635

Merged
merged 12 commits into from
Nov 7, 2024
8 changes: 4 additions & 4 deletions .github/workflows/linux_llvm_cov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install Dependencies
run: |
Expand Down Expand Up @@ -47,10 +47,10 @@ jobs:
echo "Done!"

- name: Upload Coverage Results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: llvm-cov
path: ${{ github.workspace }}/.coverage_llvm_cov
path: ${{github.workspace}}/build/.coverage_llvm_cov

- name: Create Code Coverage Report
working-directory: ${{github.workspace}}/build/tests
Expand All @@ -62,7 +62,7 @@ jobs:
echo "\`\`\`" >> tmp.log

- name: Create Comment
uses: peter-evans/create-or-update-comment@v2
uses: peter-evans/create-or-update-comment@v4
with:
issue-number: ${{ github.event.pull_request.number }}
body-file: '${{github.workspace}}/build/tests/tmp.log'
4 changes: 2 additions & 2 deletions include/cinatra/http_parser.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class http_parser {
}
if (header_len_ < 0) [[unlikely]] {
CINATRA_LOG_WARNING << "parse http head failed";
if (size == CINATRA_MAX_HTTP_HEADER_FIELD_SIZE) {
if (num_headers_ == CINATRA_MAX_HTTP_HEADER_FIELD_SIZE) {
CINATRA_LOG_ERROR << "the field of http head is out of max limit "
<< CINATRA_MAX_HTTP_HEADER_FIELD_SIZE
<< ", you can define macro "
Expand Down Expand Up @@ -75,7 +75,7 @@ class http_parser {

if (header_len_ < 0) [[unlikely]] {
CINATRA_LOG_WARNING << "parse http head failed";
if (size == CINATRA_MAX_HTTP_HEADER_FIELD_SIZE) {
if (num_headers_ == CINATRA_MAX_HTTP_HEADER_FIELD_SIZE) {
CINATRA_LOG_ERROR << "the field of http head is out of max limit "
<< CINATRA_MAX_HTTP_HEADER_FIELD_SIZE
<< ", you can define macro "
Expand Down
Loading