feat: [client] when cert path is empty, set default cert path #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage Report |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 63.19% 62.88% -0.31%
==========================================
Files 207 207
Lines 12388 12403 +15
==========================================
- Hits 7828 7800 -28
- Misses 4560 4603 +43
☔ View full report in Codecov by Sentry. |
qicosmos
reviewed
Jul 28, 2023
| @@ -252,6 +252,10 @@ class coro_http_client { | |||
| return false; | |||
| } | |||
|
|
|||
| if (base_path.empty() && cert_file.empty()) { | |||
| ssl_ctx_->set_default_verify_paths(); | |||
There was a problem hiding this comment.
Why we need to call this set_default_verify_paths()?
what the meaning of set_default_verify_paths?
is there any problem?
There was a problem hiding this comment.
details in https://gitlab.com/eidheim/Simple-WebSocket-Server/-/blame/master/client_wss.hpp#L51.
when user not have cert file, let they use openssl default cert.set_default_verify_paths will tell context search cert file in openssl default path.
problem is: When user call init_ssl("", xxx); will no cert file load?should let program load openssl default cert file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when no real-world cert file let openssl use it's default.