Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to layer and fields comboboxes in "map value" widget's Load … #59166

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Oct 22, 2024

…field from layer dialog

Before / After

image

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit af0b4fe)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit af0b4fe)

@nyalldawson
Copy link
Collaborator

Hmm... any reason why we wouldn't want to use the standard QgsMapLayerComboBox/ QgsFieldCombo widgets here?

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 22, 2024

I simply forgot they exist. Thanks for the reminder. I will do the update.

Copy link

github-actions bot commented Nov 6, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 6, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 9, 2024
@DelazJ
Copy link
Contributor Author

DelazJ commented Nov 9, 2024

I moved the widgets to use the dedicated field and map widgets and much better in the way the preview table is populated. And while at it, I added a help button and dialog geometry restoring.
I've played a lot with that dialog and i find the behavior quite confusing, but didn't address it here. This PR keeps the current behavior. See #59386 for the details on the issue.

src/gui/qgsattributetypeloaddialog.cpp Outdated Show resolved Hide resolved
src/gui/qgsattributetypeloaddialog.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson merged commit 0b43c83 into qgis:master Nov 13, 2024
29 checks passed
@DelazJ DelazJ deleted the iconsForFieldsLayers branch November 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants