Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep approve status when updating style #329

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 7, 2023

Change summary:

  • When updating a style, the status of approbation will be kept.
  • If a style has been already approved, the updated version will be automatically approved:

Style_update

  • If a style is still in review, the updated version will also still be in review:

Style_update_in_review

@dimasciput
Copy link
Collaborator

Thanks, @Xpirix. I'm going to merge this one, even though this new workflow could introduce issues and go against best practices

@dimasciput dimasciput merged commit 56c15ef into qgis:master Dec 25, 2023
2 checks passed
@Xpirix
Copy link
Collaborator Author

Xpirix commented Dec 26, 2023

Thank you @dimasciput . You're right, this new workflow needs to be discussed further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants