-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show plugins with patch versions in plugin list #325
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
- Coverage 32.51% 32.48% -0.04%
==========================================
Files 71 71
Lines 4217 4221 +4
==========================================
Hits 1371 1371
- Misses 2846 2850 +4 ☔ View full report in Codecov by Sentry. |
Hi @Xpirix, |
It seems that such version is now listed in https://plugins.qgis.org/plugins/plugins.xml?qgis=3.34. |
Hello @agiudiceandrea Thanks for the feedback. I've just deployed this PR as it was not deployed before. Best regards. |
@Xpirix @agiudiceandrea nice to see progress here 👍 Would it be possible that the plugin list could be requested also with the patch version? So for Here's a related stale PR on QGIS side to request with patch version: qgis/QGIS#47907 If the plugin repository would be able to answer requests with patch version we could revive this PR. |
This is already tracked in #222. |
Thanks @pathmapper This is also tracked in #224 and I noticed @dimasciput 's comment (#224 (comment)):
@dimasciput @timlinux Could you give me some advice on that? Thanks. |
This PR is for the issue #223
Changes summary:
According to the discussion at #224 and #224 (comment), only request with major.minor QGIS version returns results in production because the plugins xml is pre-generated.
The suggestion in issue #223 is to include the plugins with patch versions in the plugin list :
Please find below a screenshot of a test plugin with minimumVersion=3.34.1:
EDIT: This PR should also fix the issue #74